Rsync paths seem to be broken (1.5.10)

[nward]

Hi,

I am upgrading to 1.5.10, and note that the paths that are resolved for fetching certificates from RIRs are not quite right. In particular, mkdir is being called with cache/rpki.apnic.net/repository/apnic-rpki-root-iana-origin.cer, so the resulting file after rsync is cache/rpki.apnic.net/repository/apnic-rpki-root-iana-origin.cer/apnic-rpki-root-iana-origin.cer - which obviously is not what we want to happen. Same for other RIRs of course, APNIC was just an example here.

I note that there are recent changes around this - I am running 1.5.10 which should include these changes.

In #140 [1], I note that mustExtractFoldersPathFromRsyncURL was swapped out for mustExtractFilePathFromRsyncURL which I think is the cause of the issue here - though I suspect that it may have fixed a different issue when rsyncing a folder rather than a single file.

[1] https://github.com/cloudflare/cfrpki/pull/140/files#diff-f369afe0d4a19b68cd80c43aa46ae445147b43ea387c8019b93ad6888f79b200L557