octorpki metrics information - namespace, roas value and counting inaccuracy

[fendemann]

Hi,
I am in the evaluation phase of different RPKI validator software provider. For the comparison of the results I use the metrics output. Regarding this I have some questions or feature requests:

Namespace
For monitoring different metrics with one prometheus instance it is necessary to identify the domain the metric belongs to. Please use a prefix (e.g. octorpki) as described here https://prometheus.io/docs/practices/naming/

Metric value "roas"
What does the "roas" metrics exactly stands for? Counting the roa files in the cache I get a number of 48869 files which is far away form the values in the roas metric output below.

It seems, that it is a counter for vrps (validated roas payload) which is a pair of asn/prefix/maxlength. If this is true, "octorpki_vrps_total{tal=''}" would make more sence.

Counting inaccuracy
Looking deeper in the results I have extracted the data from the json file and create a csv file with one vrps (asn/prefix/maxlength/ta) per line. Doing a line grep for each tal I get the following numbers which are little lower than the values in the metric file.

Convert oktorpki.json to octorpki.csv :
Line grep and count on octorpki.csv :
[afrinic] :  1359
[apnic]   :  49342
[arin]    :  15890
[lacnic]  :  10149
[ripe]    :  95403
-----------------

ROAs per TAL Info from octorpki.metrics file :
# HELP roas Bytes received by the application.
# TYPE roas gauge
roas{ta="AFRINIC"} 1375
roas{ta="APNIC"} 49110
roas{ta="ARIN"} 17978
roas{ta="LACNIC"} 11043
roas{ta="RIPE"} 95156
-----------------

It seems, that there are some duplicate vrps in the data when you create the metrics counter. To get the real number of vrps it would be nice to create an additional metric "octorpki_vrps_unique{tal=''"}

Regards, Frank

[ties]

It seems, that there are some duplicate vrps in the data when you create the metrics counter. To get the real number of vrps it would be nice to create an additional metric "octorpki_vrps_unique{tal=''"}

For that if would be nice in my opinion if all validators standardised on a single (non-namespaced) metric name. I'm pretty sure we can achieve that. The definitions have to be identical though, that will be the hard part.