Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

Octorpki seems to be using a static user-agent #74

Open
ties opened this issue Nov 11, 2020 · 1 comment
Open

Octorpki seems to be using a static user-agent #74

ties opened this issue Nov 11, 2020 · 1 comment

Comments

@ties
Copy link

ties commented Nov 11, 2020

Hi,

When analysing HTTP access logs for a RRDP endpoint I noticed that all records for OctoRPKI have the same User-Agent

df_cf[['User-Agent', 'time']].head(1000).groupby(['User-Agent']).count().to_markdown()

User-Agent time
Cloudflare-RPKI-RRDP/1.0 (+https://rpki.cloudflare.com) 942
Cloudflare-RPKI-RRDP/1.0%20(+https://rpki.cloudflare.com) 58

It seems like the User-Agent is statically set in octorpki.go:1236. As a user doing an analysis of the adoption of newer versions of relying party software, in the future, it would help me if this header contained an indication of the version of OctoRPKI in use.

@lspgn
Copy link
Contributor

lspgn commented Nov 11, 2020

Hi @ties,
I will edit the code to make sure the current version is reflected.
Thank you for raising the issue.

lspgn added a commit that referenced this issue Nov 14, 2020
lspgn added a commit that referenced this issue Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants