-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[D1] D1 HTTP API tutorial #16412
[D1] D1 HTTP API tutorial #16412
Conversation
Deploying cloudflare-docs with Cloudflare Pages
|
Files with changes (up to 15)
|
src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 1 outstanding issue(s) found.
src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx
Outdated
Show resolved
Hide resolved
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11021221 | Triggered | Generic High Entropy Secret | 81195ad | astro.config.mjs | View secret |
11021221 | Triggered | Generic High Entropy Secret | 81195ad | astro.config.mjs | View secret |
11021221 | Triggered | Generic High Entropy Secret | 81195ad | astro.config.mjs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 1 outstanding issue(s) found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 18 outstanding issue(s) found.
src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Oxyjun left a few comments. Just some minor suggestion :D
src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx
Outdated
Show resolved
Hide resolved
@Oxyjun and @dbenCF , hyperlint developer here. I was just looking over this pull request - seems like. a lot of false comments from Hyperlint. It looks as if the problem was the indentation triggering a lot of false positives. Anything else that you think I'm missing here? cc @kodster28 for visibility. We're actively improving the model based on this information, so I want to make sure that we get it right! One of my questions is, are indentations like this common / going to be more common? |
* Add D1 http tutorial * Apply suggestions from code review Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com> * Update src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> * Finishing first review of the tutorial doc. * Finishing first review of the tutorial doc. * Clarifying language surrounding API_KEY. * Minor grammar fix * Improvements to clarity of the tutorial addressed in feedback. * Fixing broken link --------- Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com> Co-authored-by: Jun Lee <junlee@cloudflare.com> Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
* Add D1 http tutorial * Apply suggestions from code review Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com> * Update src/content/docs/d1/tutorials/build-an-api-to-access-d1/index.mdx Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com> * Finishing first review of the tutorial doc. * Finishing first review of the tutorial doc. * Clarifying language surrounding API_KEY. * Minor grammar fix * Improvements to clarity of the tutorial addressed in feedback. * Fixing broken link --------- Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com> Co-authored-by: Jun Lee <junlee@cloudflare.com> Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Updated #15779