Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax version constraints for vitest #18227

Closed
wants to merge 1 commit into from

Conversation

ocavue
Copy link

@ocavue ocavue commented Nov 17, 2024

Summary

@cloudflare/vitest-pool-workers supports the latest v2.1.x in this PR (cloudflare/workers-sdk#6716), so it might be a good idea to relax the version constraints in the documents too.

Screenshots (optional)

N/A

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions github-actions bot added the product:workers Related to Workers product label Nov 17, 2024
@ocavue ocavue marked this pull request as ready for review November 17, 2024 22:16
@GregBrimble
Copy link
Member

@penalosa , thoughts on this change?

@penalosa
Copy link
Contributor

penalosa commented Dec 9, 2024

While we do currently work with the latest 2.x version of Vitest, there's no guarantee that'll hold in future (we rely on Vitest internals that aren't covered by semver). I think we should instead update the docs to mention 2.1.8 as the latest supported version.

@GregBrimble
Copy link
Member

Thanks for your PR! However, given @penalosa's comment, I'm going to close this in favor of #18474. Appreciate the suggestion nevertheless :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants