-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workers] fix: update supported vitest version #18474
[Workers] fix: update supported vitest version #18474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 total issue(s) found.
Note: We resolved prior Hyperlint review comments because:
We updated our inline suggestion AI.
We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.
src/content/docs/workers/testing/vitest-integration/get-started/write-your-first-test.mdx
Outdated
Show resolved
Hide resolved
This works around vitest-dev/vitest#6992 being an issue with Vite 6
src/content/docs/workers/testing/vitest-integration/get-started/write-your-first-test.mdx
Outdated
Show resolved
Hide resolved
This is good to merge now, with cloudflare/workers-sdk#7384 landing in https://github.com/cloudflare/workers-sdk/releases/tag/create-cloudflare%402.33.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 total issue(s) found.
src/content/docs/workers/testing/vitest-integration/get-started/write-your-first-test.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/testing/vitest-integration/get-started/write-your-first-test.mdx
Outdated
Show resolved
Hide resolved
…d/write-your-first-test.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Congratulations @Cherry, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm4jc9mgv00730cmpd7t1fdqt This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Summary
This simply updates the supported vitest version to 2.1.8. The Workers vitest integrations works with
2.0.x - 2.1.x
.Paired with cloudflare/workers-sdk#7384