Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workers] fix: update supported vitest version #18474

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented Nov 28, 2024

Summary

This simply updates the supported vitest version to 2.1.8. The Workers vitest integrations works with 2.0.x - 2.1.x.

Paired with cloudflare/workers-sdk#7384

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 total issue(s) found.


Note: We resolved prior Hyperlint review comments because:

We updated our inline suggestion AI.

We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.

@Cherry
Copy link
Contributor Author

Cherry commented Dec 11, 2024

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 total issue(s) found.

Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GregBrimble GregBrimble enabled auto-merge (squash) December 11, 2024 03:21
@GregBrimble GregBrimble merged commit 704e3a6 into cloudflare:production Dec 11, 2024
6 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Dec 11, 2024
Copy link

holopin-bot bot commented Dec 11, 2024

Congratulations @Cherry, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm4jc9mgv00730cmpd7t1fdqt

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small product:workers Related to Workers product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants