Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

when slurm file is provided, server values are not considered. #53

Open
Avinash825 opened this issue Mar 23, 2020 · 5 comments
Open

when slurm file is provided, server values are not considered. #53

Avinash825 opened this issue Mar 23, 2020 · 5 comments

Comments

@Avinash825
Copy link

Hi,

When we pass slurm file as an argument, Global repository values are not considered. Only the locally defined addresses in slurm file are considered. is this expected ?

thanks,
Avinash C

@lspgn
Copy link
Contributor

lspgn commented Mar 23, 2020

Hello,
What do you mean by "global repository values"?
Can you provide a CLI example.

@Avinash825
Copy link
Author

i mean, the values it fetches from web without any slurm file.... i have defined few ROA's in slurm file...
{
"slurmVersion": 1,
"validationOutputFilters": {
"prefixFilters": [
],
"bgpsecFilters": [
]
},
"locallyAddedAssertions": {
"prefixAssertions": [

  {
    "asn": 13336,
    "prefix": "1.1.1.0/24",
    "maxPrefixLength": 30
  },

  {
    "asn": 13336,
    "prefix": "1.1.1.0/24",
    "maxPrefixLength": 30
  }

}
}

@lspgn
Copy link
Contributor

lspgn commented Mar 29, 2020

Do you mean the values fetched from rpki.cloudflare.com/rpki.json?
Are the asserted ROAs not added?

@Avinash825
Copy link
Author

Yes they are not added ... only locally defined values in slurm file are added..

@lspgn
Copy link
Contributor

lspgn commented Mar 30, 2020

I ran the following

$ go run gortr.go -slurm ./myslurm.json

using the SLURM you posted (it had a JSON formatting issue):

{
  "slurmVersion": 1,
  "validationOutputFilters": {
    "prefixFilters": [],
    "bgpsecFilters": []
  },
  "locallyAddedAssertions": {
    "prefixAssertions": [
      {
        "asn": 13336,
        "prefix": "1.1.1.0/24",
        "maxPrefixLength": 30
      },
      {
        "asn": 13336,
        "prefix": "1.1.1.0/24",
        "maxPrefixLength": 30
      }
    ]
  }
}

Which returned me:

$ curl --silent 127.0.0.1:8080/rpki.json | jq '.roas[] | select(.prefix=="1.1.1.0/24")'
{
  "prefix": "1.1.1.0/24",
  "maxLength": 24,
  "asn": "AS13335",
  "ta": "Cloudflare - APNIC"
}
{
  "prefix": "1.1.1.0/24",
  "maxLength": 30,
  "asn": "AS13336"
}
{
  "prefix": "1.1.1.0/24",
  "maxLength": 30,
  "asn": "AS13336"
}

This should be the expected behavior? I'm not sure what you mean.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants