From ea73accb5a63cdb3d0560b9766d6c6c7d2dfe5ec Mon Sep 17 00:00:00 2001 From: Dario Piotrowicz Date: Mon, 8 Jan 2024 22:07:04 +0100 Subject: [PATCH] fix variables not getting recorded correctly in `next-dev` (#624) --- .changeset/odd-pumpkins-sleep.md | 5 +++++ internal-packages/next-dev/src/index.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/odd-pumpkins-sleep.md diff --git a/.changeset/odd-pumpkins-sleep.md b/.changeset/odd-pumpkins-sleep.md new file mode 100644 index 000000000..e20c2f874 --- /dev/null +++ b/.changeset/odd-pumpkins-sleep.md @@ -0,0 +1,5 @@ +--- +'@cloudflare/next-on-pages': patch +--- + +fix variables not getting recorded correctly in `next-dev` diff --git a/internal-packages/next-dev/src/index.ts b/internal-packages/next-dev/src/index.ts index 05bdf6fe3..64d46e8f3 100644 --- a/internal-packages/next-dev/src/index.ts +++ b/internal-packages/next-dev/src/index.ts @@ -236,7 +236,7 @@ async function getMiniflareBindingOptions( if (bindingDetails.type === 'var') { return { ...allBindings, - bindings: { + varBindings: { ...allBindings.varBindings, [bindingName]: JSON.stringify(bindingDetails.value), },