Increased ICE disconnected timeout #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome AFAIK sends ICE checks every 2 seconds. And a single lost STUN consent (ICE ping) can result in the ICE connection state to switch to "disconnected". So the current timeout basically mean two lost STUN consents in a row result in us trying to restart the call. That might be a little to aggressive.
As indicated in the additional comment in the code: I would recommend that once ICE disconnected has been reached, that we start looking at PC stats more closely to try to figure out if we should just wait for the connection state to recover, or if we should try to restart.