Merge pull request #1137 from cloudflare/rule/duplicate

Fix panics in rule/duplicate

docs/changelog.md

@@ -6,6 +6,7 @@
 
 - Reverted `Fixed colored output on some environments - #1106` change
   as it was breaking GitHub report comments.
+- Fixed panics in [rule/duplicate](checks/rule/duplicate.md) check.
 
 ## v0.65.3
 

internal/checks/rule_duplicate.go

@@ -53,6 +53,9 @@ func (c RuleDuplicateCheck) Check(ctx context.Context, path discovery.Path, rule
 		if entry.State == discovery.Removed {
 			continue
 		}
+		if entry.PathError != nil {
+			continue
+		}
 		if entry.Rule.Error.Err != nil {
 			continue
 		}

internal/checks/rule_duplicate_test.go

@@ -1,12 +1,14 @@
 package checks_test
 
 import (
+	"errors"
 	"fmt"
 	"regexp"
 	"testing"
 	"time"
 
 	"github.com/cloudflare/pint/internal/checks"
+	"github.com/cloudflare/pint/internal/discovery"
 	"github.com/cloudflare/pint/internal/parser"
 	"github.com/cloudflare/pint/internal/promapi"
 )
@@ -32,13 +34,16 @@ func TestRuleDuplicateCheck(t *testing.T) {
 			problems:   noProblems,
 		},
 		{
-			description: "ignores alerting rules",
-			content:     "- alert: foo\n  expr: up == 0\n",
+			description: "ignores entries with path errors",
+			content:     "- record: foo\n  expr: up == 0\n",
 			checker: func(prom *promapi.FailoverGroup) checks.RuleChecker {
 				return checks.NewRuleDuplicateCheck(prom)
 			},
 			prometheus: newSimpleProm,
 			problems:   noProblems,
+			entries: []discovery.Entry{
+				{PathError: errors.New("Mock error")},
+			},
 		},
 		{
 			description: "ignores self",