Merge pull request #908 from LloydW93/lloyd/depcheck-segfault

Fix nil pointer exceptions in certain broken dependency scenarios

internal/checks/rule_dependency.go

@@ -90,12 +90,12 @@ func (c RuleDependencyCheck) Check(_ context.Context, _ string, rule parser.Rule
 
 	var details strings.Builder
 	details.WriteString("If you remove the ")
-	details.WriteString(dep.kind)
+	details.WriteString(broken[0].kind)
 	details.WriteString(" rule generating `")
-	details.WriteString(dep.metric)
+	details.WriteString(broken[0].metric)
 	details.WriteString("`, and there is no other source of this metric, then any other rule depending on it will break.\n")
 	details.WriteString("List of found rules that are using `")
-	details.WriteString(dep.metric)
+	details.WriteString(broken[0].metric)
 	details.WriteString("`:\n\n")
 	for _, b := range broken {
 		details.WriteString("- `")

internal/checks/rule_dependency_test.go

@@ -285,6 +285,34 @@ func TestRuleDependencyCheck(t *testing.T) {
 `, discovery.Noop, "foo.yaml", "foo.yaml")[0],
 			},
 		},
+		{
+			description: "warns about removed dependency without crashing if it is not the last rule",
+			content:     "- record: foo\n  expr: sum(foo)\n",
+			checker: func(_ *promapi.FailoverGroup) checks.RuleChecker {
+				return checks.NewRuleDependencyCheck()
+			},
+			prometheus: newSimpleProm,
+			problems: func(_ string) []checks.Problem {
+				return []checks.Problem{
+					{
+						Anchor: checks.AnchorBefore,
+						Lines: parser.LineRange{
+							First: 1,
+							Last:  2,
+						},
+						Reporter: checks.RuleDependencyCheckName,
+						Text:     textDependencyRule(1),
+						Details:  detailsDependencyRule("recording", "foo", "- `alert` at `foo.yaml:2`\n"),
+						Severity: checks.Warning,
+					},
+				}
+			},
+			entries: []discovery.Entry{
+				parseWithState("- record: foo\n  expr: sum(foo)\n", discovery.Removed, "foo.yaml", "foo.yaml")[0],
+				parseWithState("- alert: alert\n  expr: foo == 0\n", discovery.Noop, "foo.yaml", "foo.yaml")[0],
+				parseWithState("- record: bar\n  expr: vector(0)\n", discovery.Noop, "foo.yaml", "foo.yaml")[0],
+			},
+		},
 	}
 
 	runTests(t, testCases)