Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_pages_project has drift in source.config.preview_branch_includes #2738

Closed
2 tasks done
rsyring opened this issue Sep 5, 2023 · 1 comment
Closed
2 tasks done
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. service/pages Categorizes issue or PR as related to the Pages service. triage/accepted Indicates an issue or PR is ready to be actively worked on. triage/debug-log-attached Indicates an issue or PR has a complete Terraform debug log. workflow/synced

Comments

@rsyring
Copy link

rsyring commented Sep 5, 2023

Confirmation

  • My issue isn't already found on the issue tracker.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform v1.5.6
on linux_amd64

  • provider registry.terraform.io/cloudflare/cloudflare v4.13.0

Affected resource(s)

cloudflare_pages_project

Terraform configuration files

resource "cloudflare_pages_project" "this" {
  account_id        = local.acct_id
  name              = local.app_ident
  production_branch = local.prod_branch
  build_config {
    destination_dir = "html"
  }
  source {
    type = "github"
    config {
      owner             = "level12"
      repo_name         = "juke-demo-static"
      production_branch = local.prod_branch
      # "*" is the API default, but the CF provider doesn't set it,
      # `plan` constantly shows a change is needed if not explicit.
      # preview_branch_includes = ["*"]
    }
  }
}

Link to debug output

https://gist.github.com/rsyring/b337a5f4835e7ac9ea36012c5eea63ce

Panic output

No response

Expected output

When using config provided above and applying, on the next plan, I would expect to see no changes needed.

Actual output

When using config provided above and applying, on the next plan, I would expect to see no changes needed.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # cloudflare_pages_project.this will be updated in-place
  ~ resource "cloudflare_pages_project" "this" {
        id                = "juke-integration-test"
        name              = "juke-integration-test"
        # (5 unchanged attributes hidden)

      ~ source {
            # (1 unchanged attribute hidden)

          ~ config {
              ~ preview_branch_includes       = [
                  - "*",
                ]
                # (8 unchanged attributes hidden)
            }
        }

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Steps to reproduce

  1. Use config similar to what is tried above
  2. apply
  3. plan

Additional factoids

No response

References

No response

@rsyring rsyring added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the triage/debug-log-attached Indicates an issue or PR has a complete Terraform debug log. label Sep 5, 2023
@jacobbednarz jacobbednarz added triage/accepted Indicates an issue or PR is ready to be actively worked on. service/pages Categorizes issue or PR as related to the Pages service. labels Sep 5, 2023
@jacobbednarz jacobbednarz added service/pages Categorizes issue or PR as related to the Pages service. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed service/pages Categorizes issue or PR as related to the Pages service. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Sep 20, 2023
WalshyDev added a commit to WalshyDev/terraform-provider-cloudflare that referenced this issue Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. service/pages Categorizes issue or PR as related to the Pages service. triage/accepted Indicates an issue or PR is ready to be actively worked on. triage/debug-log-attached Indicates an issue or PR has a complete Terraform debug log. workflow/synced
Projects
None yet
Development

No branches or pull requests

2 participants