cloudflare_teams_rule having block_page_enabled to false is not idempotent

[DamienDelporte]

Cloudflare Entreprise ticket: 3019496

Confirmation

• My issue isn't already found on the issue tracker.
• I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

$ terraform version
Terraform v1.6.0
on linux_amd64
+ provider registry.terraform.io/cloudflare/cloudflare v4.18.0

Affected resource(s)

cloudflare_teams_rule

Terraform configuration files

provider "cloudflare" {
}

terraform {
  required_providers {
    cloudflare = {
      source  = "cloudflare/cloudflare"
      version = "= 4.18.0"
    }
  }
}

resource "cloudflare_teams_rule" "tf_http_allow" {
  account_id  = "XXX"
  name        = "test"
  description = "test"
  enabled     = true
  precedence  = 50
  action      = "allow"
  filters     = ["http"]
  traffic     = "http.request.uri == \"https://www.example.com/not-malicious\""
  rule_settings {
    block_page_enabled = false
  }
}

Link to debug output

Not needed.

Panic output

No response

Expected output

No changes when applying a second time (without anything new changed).

Actual output

$ terraform apply
cloudflare_teams_rule.tf_http_allow: Refreshing state... [id=XXX]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # cloudflare_teams_rule.tf_http_allow will be updated in-place
  ~ resource "cloudflare_teams_rule" "tf_http_allow" {
        id          = "XXX"
        name        = "test"
        # (8 unchanged attributes hidden)

      + rule_settings {
          + block_page_enabled = false
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: 

Steps to reproduce

1. terraform apply (to create)
2. terraform apply/plan (and see the change...)

Additional factoids

No response

References

No response

[github-actions]

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions]

Marking this issue as stale due to 30 days of inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity.

[DamienDelporte]

Still not fixed in 4.22 even if #3010 should have.

$ terraform apply
cloudflare_teams_rule.tf_http_allow: Refreshing state... [id=xxx]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # cloudflare_teams_rule.tf_http_allow will be updated in-place
  ~ resource "cloudflare_teams_rule" "tf_http_allow" {
        id          = "xxx"
        name        = "test"
        # (8 unchanged attributes hidden)

      + rule_settings {
          + block_page_enabled = false
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: no-it-is-not-fixed

Apply cancelled.