zone_settings_override minify as per documentation doesn't work

[georgekaz]

Confirmation

• This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
• I have searched the issue tracker and my issue isn't already found.
• I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform v1.5.7 ### Note: (I won't upgrade because of the license change but this is not a TF issue)
on linux_amd64

• provider registry.terraform.io/cloudflare/cloudflare v4.39.0

Affected resource(s)

cloudflare_zone_settings_override

Terraform configuration files

# cloudflare_zone_settings_override.zone_settings_override will be updated in-place
  ~ resource "cloudflare_zone_settings_override" "zone_settings_override" {
        id                       = "xxxx"
        # (6 unchanged attributes hidden)

      ~ settings {
            # (51 unchanged attributes hidden)

          + minify {
              + css  = "off"
              + html = "off"
              + js   = "off"
            }

            # (2 unchanged blocks hidden)
        }
    }

Link to debug output

https://www.github.com

Panic output

No response

Expected output

This is an old zone, this setting has been there like this for a long time, so to be honest I didn't expect the change at all. But as it's in the plan, I expect it to apply.

Actual output

│ Error: Invalid value for zone setting minify (1007)
│ 
│   with cloudflare_zone_settings_override.zone_settings_override,
│   on zone.tf line 7, in resource "cloudflare_zone_settings_override" "zone_settings_override":
│    7: resource "cloudflare_zone_settings_override" "zone_settings_override" {

Steps to reproduce

1. Follow the documentation here - https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/resources/zone_settings_override#example-usage
2. Plan
3. Apply
4. Fail

Additional factoids

Some bits from the debug logs

2024-08-15T12:23:58.037+0100 [DEBUG] provider.terraform-provider-cloudflare_v4.39.0: Cloudflare Zone Settings update configuration: []cloudflare.ZoneSetting{cloudflare.ZoneSetting{ID:"minify", Editable:false, ModifiedOn:"", Value:[]interface {}{map[string]interface {}{"css":"on", "html":"off", "js":"off"}}, TimeRemaining:0}}: tf_provider_addr=registry.terraform.io/cloudflare/cloudflare tf_req_id=651e1a09-b9f3-4ea3-31c0-394eb9940af9 tf_resource_type=cloudflare_zone_settings_override @caller=github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider/resource_cloudflare_zone_settings_override.go:300 tf_mux_provider=tf5to6server.v5tov6Server tf_rpc=ApplyResourceChange @module=cloudflare timestamp=2024-08-15T12:23:58.037+0100
...
2024-08-15T12:23:58.038+0100 [DEBUG] provider.terraform-provider-cloudflare_v4.39.0: {"items":[{"id":"minify","editable":false,"value":[{"css":"on","html":"off","js":"off"}],"time_remaining":0}]}
...
2024-08-15T12:23:59.097+0100 [DEBUG] provider.terraform-provider-cloudflare_v4.39.0: {"success":false,"errors":[{"code":1007,"message":"Invalid value for zone setting minify"}],"messages":[],"result":null}
...
2024-08-15T12:23:59.102+0100 [ERROR] provider.terraform-provider-cloudflare_v4.39.0: Response contains error diagnostic: @caller=github.com/hashicorp/terraform-plugin-go@v0.23.0/tfprotov6/internal/diag/diagnostics.go:58 @module=sdk.proto tf_proto_version=6.6 tf_req_id=651e1a09-b9f3-4ea3-31c0-394eb9940af9 tf_resource_type=cloudflare_zone_settings_override tf_rpc=ApplyResourceChange diagnostic_detail= diagnostic_severity=ERROR diagnostic_summary="Invalid value for zone setting minify (1007)" tf_provider_addr=registry.terraform.io/cloudflare/cloudflare timestamp=2024-08-15T12:23:59.101+0100
...
2024-08-15T12:23:59.109+0100 [ERROR] vertex "cloudflare_zone_settings_override.zone_settings_override" error: Invalid value for zone setting minify (1007)

Even if I change all the values to on it's the same error

    minify {
      css  = "on"
      html = "on"
      js   = "on"
    }

References

https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/resources/zone_settings_override#example-usage

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions]

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

[georgekaz]

Just found this... https://developers.cloudflare.com/fundamentals/api/reference/deprecations/#auto-minify

Seems like the docs for zone settings need updating and for Brotli field too https://developers.cloudflare.com/fundamentals/api/reference/deprecations/#brotli

[jiang-gao]

happened to us as well

[github-actions]

Marking this issue as stale due to 30 days of inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity.

[ChristophShyper]

Minify was quietly disabled by Cloudflare so now it's a constant configuration drift.

[georgekaz]

The workaround is that you have to remove the minify configuration section from your terraform code. It's no longer supported so it's now a documentation error.

…

On Tue, 19 Nov 2024, 06:03 Christopher Chow, ***@***.***> wrote: Is there a workaround for this issue? — Reply to this email directly, view it on GitHub <#3646 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKTZVF6NDCS7FLVYFQCT7D2BLIENAVCNFSM6AAAAABMSBHF56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBUG43TONJTGA> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>