Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_record don't yet support settings parameter #4595

Open
3 tasks done
sosomuse opened this issue Nov 18, 2024 · 2 comments
Open
3 tasks done

cloudflare_record don't yet support settings parameter #4595

sosomuse opened this issue Nov 18, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@sosomuse
Copy link

Confirmation

  • This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
  • I have searched the issue tracker and my issue isn't already found.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform v1.9.8
on darwin_arm64
+ provider registry.terraform.io/cloudflare/cloudflare v4.46.0

Affected resource(s)

  • cloudflare v4.46.0
    • cloudflare_record
  • cloudflare v5.0.0-alpha1
    • cloudflare_dns_record

Terraform configuration files

resource "cloudflare_record" "example" {
  zone_id = var.zone_id
  name    = "name"
  content = "IP"
  type    = "A"
  ttl     = 1
  settings = jsonencode({"flatten_cname": true})
}

Link to debug output

Probably not necessary here

Panic output

No response

Expected output

It should accept "settings" here.

Actual output

  • v4.46.0
╷
│ Error: Unsupported argument
│ 
│   on cloudflare.tf line 30, in resource "cloudflare_record" "example":
│   30:   settings = jsonencode({"flatten_cname": true})
│ 
│ An argument named "settings" is not expected here.
╵
  • v5.0.0-alpha1
│ Error: Invalid Configuration for Read-Only Attribute
│ 
│   with cloudflare_dns_record.example,
│   on cloudflare.tf line 30, in resource "cloudflare_dns_record" "example":
│   30:   settings = jsonencode({"flatten_cname": true})
│ 
│ Cannot set value for this attribute as the provider has marked it as read-only. Remove the configuration line
│ setting the value.
│ 
│ Refer to the provider documentation or contact the provider developers for additional information about
│ configurable and read-only attributes that are supported.
╵

Steps to reproduce

  1. Using 4.46.0 of terraform
  2. Create a cloudflare_record object, and specify settings field
  3. Receive error

or

  1. Using 5.0.0-alpha1 of terraform
  2. Create a cloudflare_dns_record object, and specify settings field
  3. Receive error

Additional factoids

The Cloudflare API should be able to accept a settings object when creating or updating a dns_record.
https://developers.cloudflare.com/api/operations/dns-records-for-a-zone-create-dns-record

I tried to enable CNAME flattening, but I realized that the settings parameter was not valid.
https://developers.cloudflare.com/dns/cname-flattening/set-up-cname-flattening/#per-record

I'm happy to make the PR to fix it :)

References

No response

@sosomuse sosomuse added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 18, 2024
Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link
Contributor

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

1 participant