Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test on freshly-cloned repository fails #4635

Closed
3 tasks done
mrusso19 opened this issue Nov 21, 2024 · 5 comments
Closed
3 tasks done

Make test on freshly-cloned repository fails #4635

mrusso19 opened this issue Nov 21, 2024 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@mrusso19
Copy link
Contributor

mrusso19 commented Nov 21, 2024

Confirmation

  • This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
  • I have searched the issue tracker and my issue isn't already found.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform v1.7.4
on linux_amd64

Affected resource(s)

  • internal/framework/service/turnstile/resource.go
  • internal/sdkv2provider/resource_cloudflare_teams_accounts.go

Terraform configuration files

Not important.

Link to debug output

https://gist.github.com/mrusso19/0b6a01cbe965be4b966c9126a361eef3

Panic output

No response

Expected output

I expect the test to run when using:
make test

Actual output

# github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/turnstile
internal/framework/service/turnstile/resource.go:124:17: cannot use widget.OffLabel (variable of type bool) as *bool value in struct literal
internal/framework/service/turnstile/resource.go:125:17: cannot use widget.Name (variable of type string) as *string value in struct literal
internal/framework/service/turnstile/resource.go:126:17: cannot use widget.Domains (variable of type []string) as *[]string value in struct literal
internal/framework/service/turnstile/resource.go:127:17: cannot use widget.Mode (variable of type string) as *string value in struct literal
internal/framework/service/turnstile/resource.go:128:17: cannot use widget.BotFightMode (variable of type bool) as *bool value in struct literal
# github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider
internal/sdkv2provider/resource_cloudflare_teams_accounts.go:465:14: cannot use logSettings["redact_pii"].(bool) (comma, ok expression of type bool) as *bool value in struct literal
FAIL	github.com/cloudflare/terraform-provider-cloudflare [build failed]
make: *** [GNUmakefile:28: test] Error 1

Steps to reproduce

  1. Clone the repository
  2. make test

Additional factoids

From the error logs it seems clear that the problem is using bool and not *bool.

References

No response

@mrusso19 mrusso19 added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 21, 2024
Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link
Contributor

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 21, 2024
@jacobbednarz
Copy link
Member

thanks for the heads up. this will occasionally happen as master is considered unstable. these issues are already being looked into and will be fixed in time. you can always use an earlier commit if you're after something that isn't yet released.

@jacobbednarz jacobbednarz closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
@mrusso19
Copy link
Contributor Author

thanks for the heads up. this will occasionally happen as master is considered unstable. these issues are already being looked into and will be fixed in time. you can always use an earlier commit if you're after something that isn't yet released.

FYI, I run test checking out at commit d4af222 which is the tagged one for release v4.46.0 and the errors are still there.

@jacobbednarz
Copy link
Member

looks fine here 🤷 the changes you're referring to were not merged until after that release so i suspect something else is up if you're seeing that on the release commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

2 participants