Fix behaviour of block_page_enabled block

[Nmishin]

For now, if block_page_enabled block is set - value will be updated each time regardless it set to true or false.

Fix for #2923

[github-actions]

changelog detected ✅

[jacobbednarz]

thanks for the PR here @Nmishin - looks like we're failing one of the acceptance tests though.

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsRule_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsRule_Basic
--- PASS: TestAccCloudflareTeamsRule_Basic (8.11s)
=== RUN   TestAccCloudflareTeamsRule_NoSettings
    resource_cloudflare_teams_rules_test.go:98: Step 2/2 error: Check failed: Check 8/8 error: cloudflare_teams_rule.ezalaphmxv: Attribute 'rule_settings.#' expected "0", got "1"
--- FAIL: TestAccCloudflareTeamsRule_NoSettings (10.10s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	19.019s
FAIL
make: *** [testacc] Error 1

[Nmishin]

I fixed the bug and updated the tests a bit. I think it would be better to test for values other than the default (true in our case).

[jacobbednarz]

thanks, acceptance tests all good now

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsRule_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsRule_Basic
--- PASS: TestAccCloudflareTeamsRule_Basic (8.07s)
=== RUN   TestAccCloudflareTeamsRule_NoSettings
--- PASS: TestAccCloudflareTeamsRule_NoSettings (11.27s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	19.849s

[github-actions]

This functionality has been released in v4.22.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!