Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend explicitly on the challenge to prevent some errors #3259

Merged
merged 2 commits into from
May 9, 2024

Conversation

gdubicki
Copy link
Contributor

like

"registry.terraform.io/cloudflare/cloudflare" produced an invalid new value
for .ownership_challenge: was null, but now cty.StringVal("[redacted]..[redacted]")

As recommended by @jacobbednarz in
#2752 (comment)

Workaround for issues like
#2794 #2752 #3001

like
```
"registry.terraform.io/cloudflare/cloudflare" produced an invalid new value
for .ownership_challenge: was null, but now cty.StringVal("[redacted]..[redacted]")
```

As recommended by @jacobbednarz in
cloudflare#2752 (comment)

Workaround for issues like
cloudflare#2794
cloudflare#2752
cloudflare#3001
@gdubicki gdubicki requested a review from jacobbednarz as a code owner April 22, 2024 13:10
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included and you have permission, please add the workflow/skip-changelog-entry label. Otherwise, a maintainer will add the label or ask you for one when they review the PR.

@jacobbednarz
Copy link
Member

👋 the data.aws_s3_bucket_object.challenge_file in the depends_on is redundant as the challenge_ownership value already references the datasource value. if you want to update that, we can get this merged

Copy link
Contributor

github-actions bot commented May 8, 2024

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@gdubicki
Copy link
Contributor Author

gdubicki commented May 8, 2024

👋 the data.aws_s3_bucket_object.challenge_file in the depends_on is redundant as the challenge_ownership value already references the datasource value. if you want to update that, we can get this merged

Thanks, corrected that!

@jacobbednarz jacobbednarz merged commit 7064a8d into cloudflare:master May 9, 2024
2 of 3 checks passed
@jacobbednarz
Copy link
Member

thanks!

@github-actions github-actions bot added this to the v4.33.0 milestone May 9, 2024
@gdubicki gdubicki deleted the improve-logpush-job-docs branch May 9, 2024 08:27
Copy link
Contributor

This functionality has been released in v4.33.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants