Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for creating queue consumers #3833

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

mephmanx
Copy link
Contributor

No description provided.

@mephmanx mephmanx requested a review from jacobbednarz as a code owner August 29, 2024 11:50
Copy link
Contributor

github-actions bot commented Aug 29, 2024

changelog detected ✅

Signed-off-by: Chris Lyons <52037738+mephmanx@users.noreply.github.com>
@mephmanx
Copy link
Contributor Author

mephmanx commented Aug 29, 2024

@jacobbednarz

Could you review the apaproach I took here? Also, I am having issues with what seems like writing configuration to cloudflare aand then reading the configuration back.

Also, this PR is not complete yet so dont merge...

Signed-off-by: Chris Lyons <52037738+mephmanx@users.noreply.github.com>
.gitignore Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

what do you specifically want review for the approach here? it's largely copy/paste of what we've done for other products so that seems fine.

as for the queue consumer specific stuff, i've pinged some folks internally as to how this should operate/be used since i'm not familiar with the product.

@jacobbednarz jacobbednarz marked this pull request as draft August 30, 2024 05:37
Signed-off-by: Chris Lyons <52037738+mephmanx@users.noreply.github.com>
@mephmanx
Copy link
Contributor Author

@jacobbednarz

Still working on it. If you think the approach is fine, that is all I need. I am having some difficulty with getting the schemaa right for the consumers array that I want to add to the Q object... Once I can get that working I think the rest will be pretty easy.

Signed-off-by: Chris Lyons <52037738+mephmanx@users.noreply.github.com>
@mephmanx
Copy link
Contributor Author

@jacobbednarz

Im trying to get this schema to work for the consumers:

consumers = [
{
script_name = "%[1]s"
settings {
batch_size = 1
}
}
]

as it looks like there can be multiple consumers and I want to support that. If you have any advice for how to define the schema or a better way to adjust it, let me know. Ill keep fighting with it until I get it right.

Signed-off-by: Chris Lyons <52037738+mephmanx@users.noreply.github.com>
Signed-off-by: Chris Lyons <52037738+mephmanx@users.noreply.github.com>
Signed-off-by: Chris Lyons <52037738+mephmanx@users.noreply.github.com>
Signed-off-by: Chris Lyons <52037738+mephmanx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants