New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `std::filesystem::path` instead of strings #724

Closed

apavlo opened this issue Aug 20, 2024 · 0 comments · Fixed by #726

Labels

Member

apavlo commented Aug 20, 2024

We use strings to represent filepaths all over our codebase. We should use std::filesystem::path instead to show students modern coding practices:

https://github.com/cmu-db/bustub/blob/master/src/include/common/bustub_instance.h#L244
https://github.com/cmu-db/bustub/blob/master/src/include/storage/disk/disk_manager.h#L35
https://github.com/cmu-db/bustub/blob/master/src/include/storage/index/b_plus_tree.h#L98
https://github.com/cmu-db/bustub/blob/master/src/include/storage/index/b_plus_tree.h#L114
https://github.com/cmu-db/bustub/blob/master/src/include/storage/index/b_plus_tree.h#L117
https://github.com/cmu-db/bustub/blob/master/src/include/storage/index/b_plus_tree.h#L128

The text was updated successfully, but these errors were encountered:

apavlo added the best-practice label

prashanthduvvada linked a pull request

that will close this issue

CPP Standards #726

Merged

prashanthduvvada closed this as completed in #726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment