From 182573e25ee6951460457d964225faf203cc483c Mon Sep 17 00:00:00 2001 From: Connor Tsui Date: Tue, 17 Sep 2024 15:18:56 -0400 Subject: [PATCH 1/2] add a better hint to bpm header --- src/include/buffer/buffer_pool_manager.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/include/buffer/buffer_pool_manager.h b/src/include/buffer/buffer_pool_manager.h index b7449a3ff..0bc782240 100644 --- a/src/include/buffer/buffer_pool_manager.h +++ b/src/include/buffer/buffer_pool_manager.h @@ -167,8 +167,8 @@ class BufferPoolManager { * There will likely be a lot of code duplication between the different modes of accessing a page. * * We would recommend implementing a helper function that returns the ID of a frame that is free and has nothing - * stored inside of it. Additionally, you may also want to implement a helper function that returns a shared pointer - * to a `FrameHeader` that already has a page's data stored inside of it. + * stored inside of it. Additionally, you may also want to implement a helper function that either returns a shared + * pointer to a `FrameHeader` that already has a page's data stored inside of it, or an index to said `FrameHeader`. */ }; } // namespace bustub From 9260a483492f323790f4aee764df120decba61d4 Mon Sep 17 00:00:00 2001 From: Connor Tsui Date: Tue, 17 Sep 2024 15:20:11 -0400 Subject: [PATCH 2/2] swap --- src/include/buffer/buffer_pool_manager.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/include/buffer/buffer_pool_manager.h b/src/include/buffer/buffer_pool_manager.h index 0bc782240..40d9828a7 100644 --- a/src/include/buffer/buffer_pool_manager.h +++ b/src/include/buffer/buffer_pool_manager.h @@ -167,7 +167,7 @@ class BufferPoolManager { * There will likely be a lot of code duplication between the different modes of accessing a page. * * We would recommend implementing a helper function that returns the ID of a frame that is free and has nothing - * stored inside of it. Additionally, you may also want to implement a helper function that either returns a shared + * stored inside of it. Additionally, you may also want to implement a helper function that returns either a shared * pointer to a `FrameHeader` that already has a page's data stored inside of it, or an index to said `FrameHeader`. */ };