-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_LayoutMixin mutates the prototype object panes #695
Comments
The original panes are preserved in |
Have you messed with |
In theory, if I use registry.toArray().forEach(function(item){
item.destroyRecursive();
}); It should resolve the issues. But as you might expect each widget may utilize this at different levels and I can tell already, it is going to be a big problem I think throughout cmv. I think a lot of widgets don't clean up after themselves properly when |
Why would |
Hard to know your intent when you say |
Oh, I misunderstood. So basically what I'm suggesting is this. We have a single page application where cmv is initialized based on the current state of the page. But CMV is not always loaded on the page. For example:
Basically, on that new dom node, cmv needs to be able to re-initialize itself from scratch, but if there are panes left over from the previous startup these issues will arise. |
How often can you reproduce it?
Description:
The
initPanes
function is adding properties to thethis.panes
object. This results in a object that is quite different from the default if more than one instance of cmv is created.For instance:
This should be avoided because when cmv initializes subsequent times after this object is modified, it fails because
lang.clone
is unable to handle complex objects likeBorderContainer
.Steps to reproduce:
Expected results:
CMV should be able to initialize more than once. Why? I am working on an interface that uses cmv in a single page app, and there are situations where cmv is added and removed from the page. This shouldn't be a problem.
Actual results:
CMV fails to initialize a second time.
Environment:
The text was updated successfully, but these errors were encountered: