Skip to content
This repository has been archived by the owner on May 16, 2020. It is now read-only.

GET Course from "id" example doesn't work #32

Open
paulxuca opened this issue May 16, 2016 · 5 comments
Open

GET Course from "id" example doesn't work #32

paulxuca opened this issue May 16, 2016 · 5 comments

Comments

@paulxuca
Copy link

Going to https://cobalt.qas.im/api/1.0/courses/CSC148H1F20159?key="API_KEY_HERE" resolves to:
Error 400, message: A course with the specified identifier does not exist. Maybe another example would be better here.

@kashav
Copy link
Member

kashav commented May 17, 2016

Good catch – it's happening cause the API's using course data from 2016-17 now, which means changing the year should be enough to fix it.

We're going to end up having to do this for a lot of the APIs though, since many are date/session based (exams, athletics, shuttles, etc). I personally think it'd be better just to leave it as is and add a disclaimer saying the examples might be out of date. Thoughts?

@paulxuca
Copy link
Author

That's a good idea. I was thinking (in future implementations) it could be possible to pass the year/session as a parameter.

@qasim
Copy link
Member

qasim commented May 26, 2016

@paulxuca This is something we have the data to do but it hasn't been implemented. I should make some issues about it.

@paulxuca
Copy link
Author

I could tackle that! Is all the data on the api server?

@qasim
Copy link
Member

qasim commented May 28, 2016

@paulxuca here's the corresponding issue: cobalt-uoft/cobalt#41

The data is all in the datasets repository, with each session under a tag. You can see all the tags so far here: https://github.com/cobalt-uoft/datasets/tags

Let's discuss on the other issue what you need to accomplish this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants