Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible error in code #11

Open
jdobes opened this issue Jun 16, 2015 · 2 comments
Open

Possible error in code #11

jdobes opened this issue Jun 16, 2015 · 2 comments
Labels
bug

Comments

@jdobes
Copy link
Contributor

jdobes commented Jun 16, 2015 •
edited by SchoolGuy
Loading

There are statements introduced by PR #1294 in koan/app.py like:

elif breed == "redhat" and (os_version >= "rhel7" or os_version >= "fedora17"):

However, statement "rhel6" >= "fedora17" is evaluated as True in Python. Am I correct?
opoplawski added a commit that referenced this issue Dec 2, 2015
@opoplawski
Fix os_version conditionals (issue #11)
5453dbc
@opoplawski
Copy link
Contributor

You are indeed. This should fix I believe.

jmaas added a commit that referenced this issue Dec 3, 2015
@jmaas
Merge pull request #14 from cobbler/osver
e7e31fb 
Fix os_version conditionals (issue #11)
@jmaas
Copy link
Member

jmaas commented Jan 22, 2016

Note to self: check if this needs backporting to 2.8

@SchoolGuy SchoolGuy added the bug label Jul 31, 2019
@SchoolGuy SchoolGuy moved this to Bug Reports in Koan Sep 26, 2022
@SchoolGuy SchoolGuy added this to Koan Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Koan
Status: Bug Reports
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jmaas @opoplawski @jdobes @SchoolGuy