From f1fe2a14915afdd771f07b0f93b4ffe1838d2a76 Mon Sep 17 00:00:00 2001 From: Martin Pitt Date: Fri, 3 Nov 2023 06:16:47 +0100 Subject: [PATCH] test: Reduce error message expectation for unreachable tang server stratis 3.6.0 changed its implementation from calling the cryptsetup CLI to the API. This made the error message for an unreachable tang server rather useless: > Cryptsetup error: IO error occurred: Operation not permitted (os error 1)" That is reported in https://bugzilla.redhat.com/show_bug.cgi?id=2246920 but fixing this will take a while. In the meantime, don't skip the rest of the test via the naughty, but just adjust to current reality. After that we can drop https://github.com/cockpit-project/bots/issues/5469 --- test/verify/check-storage-stratis | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/verify/check-storage-stratis b/test/verify/check-storage-stratis index 5321f2519e0..27680adf943 100755 --- a/test/verify/check-storage-stratis +++ b/test/verify/check-storage-stratis @@ -890,7 +890,10 @@ class TestStorageStratisNBDE(packagelib.PackageCase, storagelib.StorageCase): tang_m.execute("systemctl stop tangd.socket") b.click('#detail-header button:contains(Start)') self.dialog_wait_open() - b.wait_in_text("#dialog", "Error communicating") + # stratis' error message for unreachable tang server is very poor: + # https://bugzilla.redhat.com/show_bug.cgi?id=2246920 Version < 3.6.0 said + # "Error communicating with server 10.111.112.5", check this again after fixing + b.wait_in_text("#dialog", "Error") self.dialog_cancel() self.dialog_wait_close()