Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readyLatency in AvalonSTMonitor not working #13

Open
hjmedenblik opened this issue Apr 14, 2020 · 3 comments
Open

readyLatency in AvalonSTMonitor not working #13

hjmedenblik opened this issue Apr 14, 2020 · 3 comments

Comments

@hjmedenblik
Copy link

Hi,
I am testing my AvalonST packet device. But my hdl assumes readyLatency=1. I see that the config of readyLatency is defined in the monitors/avalon.py but the implementation is missing.
I suggest to add a shiftregister functionality based on the readyLatency param and applied to self.bus.ready.value. That one can then be used in the def valid()

tnx
Henk

@cmarqu
Copy link
Contributor

cmarqu commented May 12, 2020

@ktbarrett ktbarrett transferred this issue from cocotb/cocotb Jan 30, 2021
@gardintrapp
Copy link

According to the Avalon specifications for the case where readyAllowance = readyLatency : When readyLatency is not 0, the source must deassert valid on non-ready cycles.
A simple fix may be to only look at valid in def valid() if readyLatency is set to any other value than 0. This fix worked for me.

@imphil
Copy link
Member

imphil commented Jan 25, 2023

@gardintrapp would you mind opening a pull request with your enhancement? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants