Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0 decisions - what to expect - suggestions welcomed #105

Open
codekidX opened this issue Mar 20, 2019 · 5 comments
Open

v3.0 decisions - what to expect - suggestions welcomed #105

codekidX opened this issue Mar 20, 2019 · 5 comments
Assignees
Milestone

Comments

@codekidX
Copy link
Owner

Hello,

It has been around 4 months since the development and I would want to thank all the developers and stargazers to help me support and motivate me in making this library the best.

For 3.0 I had made a decision to develop the project with the latest frameworks and work around with activities instead of dialogs and it has turned out to be rather a long road towards releasing the version with the current state of the project and want to proceed to develop with the same code base.

So here are my thoughts for 3.0:

  1. Material design 2.0 compliant design (expect the best design ever)
  2. New dialog for Image and Video files (with latest Android Q API changes)
  3. All the old issues fixed and suggestions incorporated (marked for 3.0 milestone)
  4. Thumbnails on image files in file chooser
@codekidX codekidX added this to the 3.0 milestone Mar 20, 2019
@codekidX codekidX self-assigned this Mar 20, 2019
@TejrajJadhav
Copy link

TejrajJadhav commented Mar 22, 2019 via email

@kia1349
Copy link

kia1349 commented Sep 5, 2019

thanks a lot
i am waiting too

@innerman
Copy link

I really appreciate your work! Yor library is very useful and works fine on my project. Thanks a lot !
Here are some suggestions for the future:
In FILE_PICKER mode:

  • optional show circular progress indicator instead of the linear one
  • optional show size and/or date of the files found

@vidicunt
Copy link

vidicunt commented Apr 5, 2020

Congratulations on the library! I love it. Thank you

There are a few suggestions I'd like to add:

  • The dialog doesn't follow my app theme colors, instead there's a green color used
  • Removing android:configchanges requirement from the Manifest - this usually means bad practice of saved states
  • Ripple on all the buttons (as per material guidelines)
  • There's lots of strictmode activity when opening the dialog

@codekidX codekidX pinned this issue Jan 24, 2021
@BenjaminTGa
Copy link

Love how simple this library is to use. Thanks for making it.
A suggestion: could you make this library use Material 3, not Material 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants