Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry altool --upload-app on return codes -5 and -11 #435

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

fran-tirapu
Copy link
Contributor

@fran-tirapu fran-tirapu commented Nov 6, 2024

Application loader tool can exit unexpectedly with return code -5 or -11 when running altool --upload-app without any error or warning messages in log output even though the application binary and authentication information are both valid. Subsequent altool --upload-app calls using the same binary can complete normally.

Handle such unexpected exits by enabling retrying for those exit codes.

Updated actions:

  • app-store-connect publish

@priitlatt priitlatt changed the title altool retry by return codes -5 and -11 Retry altool --upload-app on return codes -5 and -11 Nov 6, 2024
Copy link
Contributor

@priitlatt priitlatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks great. It just bugs me a little to call something "unknown" if we know its exact value. So I suggest to use "unexpected" instead.

CHANGELOG.md Outdated Show resolved Hide resolved
src/codemagic/models/altool/altool.py Outdated Show resolved Hide resolved
tests/models/altool/test_altool_retrying.py Outdated Show resolved Hide resolved
@fran-tirapu fran-tirapu marked this pull request as ready for review November 6, 2024 14:41
@fran-tirapu fran-tirapu merged commit 11e98a6 into master Nov 6, 2024
11 checks passed
@fran-tirapu fran-tirapu deleted the bugfix/altool-retry-by-exit-code branch November 6, 2024 14:42
@priitlatt priitlatt added the enhancement New feature or request label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants