Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graceful handling for missing bundle ID identifer on app-store-connect fetch-signing-files action #438

Merged

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Nov 7, 2024

App Store Connect list bundle IDs API endpoint requires that parameter filter[identifier] is not an empty string. Currently this is not enforced by app-store-connect fetch-signing-files and can result in weird error message that does not translate well into executed CLI command.

Apply runtime parameter validation and raise an argument error in case empty identifier is used:

% app-store-connect fetch-signing-files ''
usage: app-store-connect [-h] [--log-stream {stderr,stdout}] [--no-color] [--version] [-s] [-v]
                   {app-store-version-localizations,app-store-version-phased-releases,app-store-version-submissions,app-store-versions,apps,beta-app-review-submissions,beta-build-localizations,beta-groups,buildsbundle-idget-bundle-icertificatedevicefetch-signing-files,get-latest-app-store-build-number,get-latest-build-number,get-latest-testflight-build-number,profilesdelete-profilpublish,review-submission-items,review-submissions}
                   ...
app-store-connect: error: argument bundle_id_identifier: Bundle ID identifier must be specified, empty values are not allowed. For example "com.example.app".

Updated actions:

  • app-store-connect fetch-signing-files

Copy link
Contributor

@fran-tirapu fran-tirapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priitlatt priitlatt merged commit 369bc51 into master Nov 7, 2024
11 checks passed
@priitlatt priitlatt deleted the improvement/fetch-signing-files-bundle-id-argument branch November 7, 2024 12:42
@priitlatt priitlatt added enhancement New feature or request app-store-connect labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store-connect enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants