You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was writing some one-off Alpha Vantage API calls in my portfolio analysis program when I ran up against the rate limitations of 5 API calls per minute (100 per day) on the FREE api key. The API does not provide any rate info in the response headers, so I had to do a one-off on the task I was working.
Then I remember that I outta check RubyGems to see if anyone had already written a gem for this API. Found yours. Reviewed the code. It is nice and clean. Very impressive. I liked the way you grouped the indicators.
What I was thinking is that we need to have some kind of program wide rate monitoring. The place to put that would be in the client. Its been two years and you have an outstanding PR against the README file. Have you burned out on this gem?
The text was updated successfully, but these errors were encountered:
Hey @MadBomber thanks for the comment. I'm not actively working on this gem at the moment. I'm also not receiving any notifications in my inbox for all the new PRs and comments for some reason.
Let me know if you want to be actively maintaining this gem. Happy to add you as an approver as well.
Thank you for considering me for that. Let me think about that for a while.
I think your gem is pretty good. Daniel did have a point with his pull
request from last year on a simple addition to the README.md file. I think
you should accept or reject that PR as well. It does not look good when a
gem has outstanding PRs.
Dewayne
o-*
On Fri, Sep 29, 2023 at 2:58 PM Adrian Teh ***@***.***> wrote:
Hey @MadBomber <https://github.com/MadBomber> thanks for the comment. I'm
not actively working on this gem at the moment. I'm also not receiving any
notifications in my inbox for all the new PRs and comments for some reason.
Let me know if you want to be actively maintaining this gem. Happy to add
you as an approver as well.
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFE3LEBBSAVWD4VWU7I6TX44R43ANCNFSM6AAAAAA5ETH46U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
I was writing some one-off Alpha Vantage API calls in my portfolio analysis program when I ran up against the rate limitations of 5 API calls per minute (100 per day) on the FREE api key. The API does not provide any rate info in the response headers, so I had to do a one-off on the task I was working.
Then I remember that I outta check RubyGems to see if anyone had already written a gem for this API. Found yours. Reviewed the code. It is nice and clean. Very impressive. I liked the way you grouped the indicators.
What I was thinking is that we need to have some kind of program wide rate monitoring. The place to put that would be in the client. Its been two years and you have an outstanding PR against the README file. Have you burned out on this gem?
The text was updated successfully, but these errors were encountered: