Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C++ backend for all the trees present in binary_trees.py #550

Open
czgdp1807 opened this issue Dec 21, 2023 · 6 comments
Open

Add C++ backend for all the trees present in binary_trees.py #550

czgdp1807 opened this issue Dec 21, 2023 · 6 comments

Comments

@czgdp1807
Copy link
Member

Description of the problem

https://github.com/codezonediitj/pydatastructs/blob/main/pydatastructs/trees/binary_trees.py

Follow the pattern of C++ backend in linear_data_structures module.

Check https://github.com/codezonediitj/pydatastructs/tree/main/pydatastructs/linear_data_structures/_backend/cpp

Example of the problem

References/Other comments

@czgdp1807
Copy link
Member Author

@Kishan-Ved Go ahead and take this up.

@Kishan-Ved
Copy link
Contributor

Sure, I'll start working on this. Thank you!

@Kishan-Ved
Copy link
Contributor

Kishan-Ved commented Dec 22, 2023

I've spent the day reading and understanding backend implementation of search algorithms. However, I'm finding it difficult to understand how to start the implementation from scratch, which files to include and which already defined utils to use.
Can you please commit some starting code, which has files created with necessary imports and the BinaryTree class' backend implemented in c++. (it is a small code defined in binary_trees.py). Also please let me know if nodes are already defined in c++ backend.
This will help me understand and reuse the code to implement other classes.

@czgdp1807
Copy link
Member Author

I won’t be able to do that. Try checking how OneDimensionalArray is implemented. Follow the same pattern here.

@Kishan-Ved
Copy link
Contributor

Please check this once: #551

@Kishan-Ved
Copy link
Contributor

The C++ backend is complete, we can close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants