Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for dynamic and important plugins #245

Open
daywalker90 opened this issue Feb 26, 2024 · 1 comment
Open

Better support for dynamic and important plugins #245

daywalker90 opened this issue Feb 26, 2024 · 1 comment
Assignees
@vincenzopalazzo
Labels
💭 - brainstorming feature idea and related discussion enhancement New feature or request
Milestone
0.1-rc1

Comments

@daywalker90
Copy link
Collaborator

I identified a few issues related to the title:

  • dynamic plugins are not added to the internal state, so things like listor remove don't work
  • help text should make clear that enable and disable are for static plugins only and make a start and stop command for dynamic plugins
    • OR overload enable and disable for dynamic plugins to be their start and stop
  • using remove should stop a dynamic plugin
  • plugin authors need to be able to mark their plugin important in the manifest and coffee should support that

I can make pr's for these if you like, but i wanted to gather some feedback first.
@vincenzopalazzo
Copy link
Contributor

There are really good points thanks, I think we should implement these too before our 0.1.0-rc1 because looks like basic functionalities

@vincenzopalazzo vincenzopalazzo added this to the 0.1-rc1 milestone Feb 26, 2024
@vincenzopalazzo vincenzopalazzo self-assigned this Feb 26, 2024
@vincenzopalazzo vincenzopalazzo added enhancement New feature or request 💭 - brainstorming feature idea and related discussion labels Feb 26, 2024
daywalker90 added a commit to daywalker90/coffee that referenced this issue Feb 27, 2024
@daywalker90
feat(core): consistent dynamic plugins install/remove
7eb089b 
dynamic plugins now get saved persistently
on remove dynamic plugins get stopped
do not return on every Err, if it's expected

part of coffee-tools#245
@daywalker90 daywalker90 mentioned this issue Feb 27, 2024
Merged
daywalker90 added a commit to daywalker90/coffee that referenced this issue Feb 27, 2024
@daywalker90
feat: support important plugins
62c8fa0 
added a new manifest field to mark plugin as important
only install as static and important

part of coffee-tools#245
@daywalker90 daywalker90 mentioned this issue Feb 27, 2024
Merged
vincenzopalazzo pushed a commit that referenced this issue Mar 1, 2024
@daywalker90 @vincenzopalazzo
feat(core): consistent dynamic plugins install/remove
6efaf27 
dynamic plugins now get saved persistently
on remove dynamic plugins get stopped
do not return on every Err, if it's expected

part of #245
daywalker90 added a commit to daywalker90/coffee that referenced this issue Mar 1, 2024
@daywalker90
feat: support important plugins
8075ac8 
added a new manifest field to mark plugin as important
only install as static and important

part of coffee-tools#245
vincenzopalazzo pushed a commit that referenced this issue Mar 1, 2024
@daywalker90 @vincenzopalazzo
feat: support important plugins
f4208f9 
added a new manifest field to mark plugin as important
only install as static and important

part of #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincenzopalazzo vincenzopalazzo

Labels
💭 - brainstorming feature idea and related discussion enhancement New feature or request
Projects
None yet
Milestone
0.1-rc1
Development

No branches or pull requests
2 participants
@daywalker90 @vincenzopalazzo