Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Validation in Command Line Inputs #270

Closed
tareknaser opened this issue Apr 15, 2024 · 6 comments · Fixed by #274
Closed

Network Validation in Command Line Inputs #270

tareknaser opened this issue Apr 15, 2024 · 6 comments · Fixed by #274
Assignees
Labels
🐛 - bug Something isn't working 👶 - good first issue Good for newcomers
Milestone

Comments

@tareknaser
Copy link
Collaborator

Description

Currently, coffee does not validate if the network supplied in the command line is valid.
Running coffee -n remote list by mistake creates /Users/tareknasser/.coffee/remote

@tareknaser tareknaser added the 🐛 - bug Something isn't working label Apr 15, 2024
@tareknaser tareknaser self-assigned this Apr 15, 2024
@vincenzopalazzo vincenzopalazzo added the 👶 - good first issue Good for newcomers label Apr 15, 2024
@vincenzopalazzo
Copy link
Contributor

I did too :) we should validate the network is one of the cln supported one

Shoulds be really trivial

@vincenzopalazzo vincenzopalazzo added this to the 0.1-rc1 milestone Apr 15, 2024
@Anyitechs

This comment was marked as off-topic.

@vincenzopalazzo
Copy link
Contributor

@Anyitechs there is no need to ask or advertize that you are working on some issue, just open a PR

@Anyitechs

This comment was marked as off-topic.

@Anyitechs

This comment was marked as off-topic.

@vincenzopalazzo
Copy link
Contributor

Marking the commit as out of scope, please @Anyitechs do not use the github issue as a direct chat with the maintainer, if maintainer want to be reached they have an email in the github profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 - bug Something isn't working 👶 - good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants