Omit runtime dependencies from build ordering #567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will allow a package which has only a runtime dependency on another package to be built independently. It will not affect the dependency-based package selection behavior, but could make the build graph a little more shallow.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 81.88% 81.76% -0.12%
==========================================
Files 62 62
Lines 3648 3658 +10
Branches 705 709 +4
==========================================
+ Hits 2987 2991 +4
- Misses 609 613 +4
- Partials 52 54 +2
☔ View full report in Codecov by Sentry. |
|
Ah, this isn't quite enough. Export dependencies of ROS packages are indistinguishable from exec dependencies in this context, so we need a change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow a package which has only a runtime dependency on another package to be built independently. It will not affect the dependency-based package selection behavior, but could make the build graph a little more shallow.