Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ResourceWarning suppression #581

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Sep 5, 2023

This suppression is no longer necessary after the fix introduced as part of #573.

@cottsay cottsay added the bug Something isn't working label Sep 5, 2023
@cottsay cottsay self-assigned this Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e6cf296) 81.93% compared to head (6639183) 81.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files          65       65           
  Lines        3753     3753           
  Branches      724      724           
=======================================
  Hits         3075     3075           
  Misses        622      622           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This suppression is no longer necessary after the fix introduced as part
of 74a6705.
@cottsay cottsay changed the title Address ResourceWarning during tests Drop ResourceWarning suppression Sep 6, 2023
@cottsay cottsay marked this pull request as ready for review September 6, 2023 21:50
@cottsay cottsay merged commit 3241f1c into master Sep 13, 2023
35 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/resource-warning branch September 13, 2023 15:36
@cottsay cottsay modified the milestone: 0.13.0 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants