Add more tests for task.python.build #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
==========================================
+ Coverage 81.96% 83.32% +1.35%
==========================================
Files 65 65
Lines 3759 3759
Branches 725 725
==========================================
+ Hits 3081 3132 +51
+ Misses 623 551 -72
- Partials 55 76 +21 ☔ View full report in Codecov by Sentry. |
cottsay
force-pushed
the
cottsay/more-build-tests
branch
from
66705cc
to
8f115d6
Compare
A high-level view of this change: * Take test_build_python and move the majority of the content to _test_build_python * Make it tolerant of multiple invocations * Write a new test_build_python that just calls the new function * Write a _symlink variant * Write a _symlink_first variant which invokes the function twice * Write a _symlink_second variant which inverts the order
cottsay
force-pushed
the
cottsay/more-build-tests
branch
from
8f115d6
to
61dfd7b
Compare
j-rivero
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A high-level view of this change:
Requires #579