Fix compatibility with Python < 3.10 importlib.metadata #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the Distribution.name property was introduced in Python 3.10. Fixes: 5f9f5ff
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #585 +/- ##
=======================================
Coverage 83.32% 83.32%
=======================================
Files 65 65
Lines 3759 3760 +1
Branches 725 725
=======================================
+ Hits 3132 3133 +1
Misses 551 551
Partials 76 76
☔ View full report in Codecov by Sentry. |
nuclearsandwich
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the Distribution.name property was introduced in Python 3.10.
It would have been nice if CI would have caught this before I tagged the release.
Fixes #562