Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert from using importlib.metadata back to pkg_resources #587

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Revert from using importlib.metadata back to pkg_resources #587

merged 1 commit into from
Oct 2, 2023

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Oct 2, 2023

It appears that we accidentally shipped this incompatible change on Ubuntu Bionic, which is currently under ESM. While we do intend to drop mainline support for Bionic, we should leave it in a good state.

The plan is to release this change in a new version of colcon-core and then immediately drop bionic from the deb releases, revert this change, and then ship another new version of colcon-core which restores the current state.

This reverts #585
This reverts #562
This reverts #560

@cottsay
Revert from using importlib.metadata back to pkg_resources
1d23526 
It appears that we accidentally shipped this incompatible change on
Ubuntu Bionic, which is currently under ESM. While we do intend to drop
mainline support for Bionic, we should leave it in a good state.

This reverts commit a9de909.
This reverts commit 5f9f5ff.
This reverts commit 7b70e61.
@cottsay cottsay added the bug Something isn't working label Oct 2, 2023
@cottsay cottsay self-assigned this Oct 2, 2023
@cottsay cottsay linked an issue Oct 2, 2023 that may be closed by this pull request
colcon-core 0.13.1python3.8 dependency breaks ROS 2 Dashing #586
Closed
@cottsay cottsay added this to the 0.13.2 milestone Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (2ce42f1) 83.32% compared to head (1d23526) 83.38%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   83.32%   83.38%   +0.05%     
==========================================
  Files          65       65              
  Lines        3760     3755       -5     
  Branches      725      728       +3     
==========================================
- Hits         3133     3131       -2     
+ Misses        551      547       -4     
- Partials       76       77       +1
Files Coverage Δ
colcon_core/plugin_system.py 98.68% <100.00%> (ø)
colcon_core/task/python/test/pytest.py 28.75% <33.33%> (ø)
colcon_core/package_identification/python.py 69.64% <0.00%> (+6.73%) ⬆️
colcon_core/extension_point.py 86.48% <78.12%> (-3.93%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

j-rivero
j-rivero approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to reproduce the result revering the commits locally. LGTM.

@cottsay cottsay merged commit 731092b into master Oct 2, 2023
35 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/back-to-pkg-resources branch October 2, 2023 18:42
@cottsay cottsay mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees

@cottsay cottsay

Labels
bug Something isn't working
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

colcon-core 0.13.1python3.8 dependency breaks ROS 2 Dashing
2 participants
@cottsay @j-rivero