Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin version of empy to <4 #603

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

claraberendsen
Copy link
Contributor

@claraberendsen claraberendsen commented Nov 30, 2023

Description

Due to the new release of empy 4, CI has been broken since colcon broke with it. See:

This PR pins the dependency to <4 .

@claraberendsen claraberendsen changed the title pin version of empy to 3.3.4 pin version of empy to <4 Nov 30, 2023
setup.cfg Outdated Show resolved Hide resolved
stdeb.cfg Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6aef15) 83.32% compared to head (22bdb72) 83.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   83.32%   83.32%           
=======================================
  Files          65       65           
  Lines        3760     3760           
  Branches      725      725           
=======================================
  Hits         3133     3133           
  Misses        551      551           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay added the bug Something isn't working label Nov 30, 2023
@cottsay cottsay self-assigned this Nov 30, 2023
@cottsay cottsay added this to the 0.15.1 milestone Nov 30, 2023
@cottsay cottsay merged commit a685ec8 into colcon:master Nov 30, 2023
35 checks passed
@claraberendsen claraberendsen deleted the claraberendsen/pin-empy branch November 30, 2023 14:43
@cottsay cottsay linked an issue Nov 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

empy version incompatibility
2 participants