Refactor python build test to improve coverage #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cottsay
force-pushed
the
cottsay/python-build-test-coverage
branch
from
90701a9
to
66f51ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
==========================================
+ Coverage 83.24% 83.66% +0.42%
==========================================
Files 65 65
Lines 3765 3765
Branches 728 728
==========================================
+ Hits 3134 3150 +16
+ Misses 555 541 -14
+ Partials 76 74 -2 ☔ View full report in Codecov by Sentry. |
cottsay
force-pushed
the
cottsay/python-build-test-coverage
branch
2 times, most recently
from
3f5d2ce
to
3664418
Compare
nuclearsandwich
approved these changes
Feb 2, 2024
| @@ -94,108 +147,44 @@ def _test_build_package(tmp_path_str, *, symlink_install): | |||
| build_base = Path(python_build_task.context.args.build_base) | |||
| assert build_base.rglob('my_module/__init__.py') | |||
|
|
|||
| return Path(python_build_task.context.args.install_base) | |||
There was a problem hiding this comment.
Since we no longer return anything from this function I went through the diff to make sure we've dropped all calls that save a return value and it appears we do.
|
Thanks for the review. Even though the code coverage didn't improve very much with this change, I believe it covers some critical use cases that were previously gaps in our testing. |
cottsay
force-pushed
the
cottsay/python-build-test-coverage
branch
from
6888abc
to
f7a6d05
Compare
Switching to a parametrized approach also significantly reduces duplicated code in the test.
cottsay
force-pushed
the
cottsay/python-build-test-coverage
branch
from
f7a6d05
to
c5a3d1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to a parametrized approach also significantly reduces duplicated code in the test.