Switch to workflow_call for GitHub Actions CI #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 83.32% 83.37% +0.05%
==========================================
Files 66 66
Lines 3789 3789
Branches 737 737
==========================================
+ Hits 3157 3159 +2
+ Misses 557 556 -1
+ Partials 75 74 -1 ☔ View full report in Codecov by Sentry. |
cottsay
force-pushed
the
cottsay/workflow-call
branch
from
04cee95
to
adaaf91
Compare
cottsay
force-pushed
the
cottsay/workflow-call
branch
from
adaaf91
to
584eae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches colcon-core to use the new
workflow_call-based solution for centralized CI definitions. It substantially reduces the boilerplate needed in each repository.Once this change is merged, I'll make a corresponding change in each colcon extension.