Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress setup.py deprecation warnings during build #626

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 11, 2024

This warning is legitimate and something that developers should be aware of, but at present, the replacement does not provide all of the functionality necessary to support the currently available features in colcon.

When that changes, we'll communicate the upgrade path to users and re-enable the deprecation warning.

Related to #454, #208

This warning is legitimate and something that developers should be aware
of, but at present, the replacement does not provide all of the
functionality necessary to support the currently available features in
colcon.

When that changes, we'll communicate the upgrade path to users and
re-enable the deprecation warning.
@cottsay cottsay self-assigned this Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.32%. Comparing base (c7d8194) to head (98e30ff).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
- Coverage   83.37%   83.32%   -0.06%     
==========================================
  Files          66       66              
  Lines        3789     3789              
  Branches      737      737              
==========================================
- Hits         3159     3157       -2     
- Misses        556      557       +1     
- Partials       74       75       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks for doing this.

@cottsay cottsay merged commit a6631ed into master Mar 11, 2024
42 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/setup-py-deprecation branch March 11, 2024 23:00
@cottsay cottsay added this to the 0.15.3 milestone Mar 11, 2024
@cottsay cottsay added the enhancement New feature or request label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants