Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alternate group names in get_*_extensions #647

Merged
merged 4 commits into from
May 24, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented May 22, 2024

These functions are brief, but it would be nice not to have to duplicate them in other colcon packages which re-use the same extension frameworks.

These functions are brief, but it would be nice not to have to duplicate
them in other colcon packages which re-use the same extension
frameworks.
@cottsay cottsay added the enhancement New feature or request label May 22, 2024
@cottsay cottsay self-assigned this May 22, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 71.15385% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 83.18%. Comparing base (b174608) to head (fe660e8).
Report is 1 commits behind head on master.

Files Patch % Lines
colcon_core/task/python/test/__init__.py 25.00% 3 Missing ⚠️
colcon_core/shell/__init__.py 75.00% 0 Missing and 2 partials ⚠️
colcon_core/argument_parser/__init__.py 75.00% 0 Missing and 1 partial ⚠️
colcon_core/environment/__init__.py 75.00% 0 Missing and 1 partial ⚠️
colcon_core/event_handler/__init__.py 75.00% 0 Missing and 1 partial ⚠️
colcon_core/executor/__init__.py 75.00% 0 Missing and 1 partial ⚠️
colcon_core/package_augmentation/__init__.py 75.00% 0 Missing and 1 partial ⚠️
colcon_core/package_discovery/__init__.py 75.00% 0 Missing and 1 partial ⚠️
colcon_core/package_identification/__init__.py 75.00% 0 Missing and 1 partial ⚠️
colcon_core/package_selection/__init__.py 75.00% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage   83.43%   83.18%   -0.26%     
==========================================
  Files          66       66              
  Lines        3816     3842      +26     
  Branches      745      758      +13     
==========================================
+ Hits         3184     3196      +12     
- Misses        555      557       +2     
- Partials       77       89      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay merged commit db84706 into master May 24, 2024
36 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/group_names branch May 24, 2024 18:22
@cottsay cottsay added this to the 0.16.2 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants