Make BypassStdoutInterpreter compatible with EmPy 4.x #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #664 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 67 67
Lines 3914 3914
Branches 776 776
=======================================
Hits 3419 3419
Misses 391 391
Partials 104 104 ☔ View full report in Codecov by Sentry. |
clalancette
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing much really changes here, but EmPy 4.x does some confusing things with the
outputoption whenuseProxyisFalse, which we must set (in a separate change) to deal with stdout getting flushed/closed/etc.In addition to keeping EmPy from modifying
sys.stdout, this change also aligns the behavior of EmPy 4.x with 3.x with regard to theoutputoption. IMO this is a bug in 4.x, but I don't really have the energy to figure out how to report it.