Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for reading and caching PEP 518 spec #668

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Sep 20, 2024

This code was originally part of the colcon-python-project package. I intend to bring that code into colcon-core with proper tests, and hide the functionality behind a feature flag until we're ready to make it the default.

This change specifically adds code to read and cache the pyproject.toml spec on package descriptors.

@cottsay cottsay added the enhancement New feature or request label Sep 20, 2024
@cottsay cottsay self-assigned this Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (fbbb8af) to head (32653b5).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
- Coverage   87.35%   87.05%   -0.30%     
==========================================
  Files          67       67              
  Lines        3921     3939      +18     
  Branches      775      696      -79     
==========================================
+ Hits         3425     3429       +4     
- Misses        392      404      +12     
- Partials      104      106       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay merged commit 52d96e9 into master Sep 26, 2024
36 checks passed
@cottsay cottsay deleted the cottsay/pyproject-spec branch September 26, 2024 18:59
@cottsay cottsay added this to the 0.17.2 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants