Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior when tasks raise exceptions #30

Open
cottsay opened this issue Aug 2, 2023 · 0 comments
Open

Inconsistent behavior when tasks raise exceptions #30

cottsay opened this issue Aug 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@cottsay
Copy link
Member

cottsay commented Aug 2, 2023

When an exception is raised in a task using the sequential executor in colcon_core, the executor stops processing jobs immediately regardless of the on_error behavior and returns 1.

In the parallel executor, it seems that exceptions are treated the same as a non-zero exit code and on_error is used to determine the behavior.

The resulting error message in the colcon executor code makes it sound like the exception originated from an error in the executor itself, but the return code does eventually get changed to 1 to match the sequential executor. Regardless, the on_error behavior difference is noteworthy.

@cottsay cottsay added the bug Something isn't working label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant