From 3c4d291b894dab87c98f64a12e1a83fb21fe4809 Mon Sep 17 00:00:00 2001
From: Scott K Logan <logans@cottsay.net>
Date: Fri, 4 Oct 2024 13:57:48 -0500
Subject: [PATCH] Port some identification/augmentation tests from colcon_core
 (#60)

This change contains a trimmed port of the Python package identification
and augmentation tests from colcon_core.
---
 test/spell_check.words                        |  3 +
 ..._package_identification_python_setup_py.py | 89 +++++++++++++++++++
 2 files changed, 92 insertions(+)
 create mode 100644 test/test_package_identification_python_setup_py.py

diff --git a/test/spell_check.words b/test/spell_check.words
index 7bc1d53..f2860c8 100644
--- a/test/spell_check.words
+++ b/test/spell_check.words
@@ -1,8 +1,10 @@
 apache
+basepath
 chdir
 colcon
 contextlib
 distclass
+foobar
 hashable
 iterdir
 linter
@@ -18,4 +20,5 @@ runpy
 scspell
 setuptools
 stacklevel
+tempfile
 thomas
diff --git a/test/test_package_identification_python_setup_py.py b/test/test_package_identification_python_setup_py.py
new file mode 100644
index 0000000..88b2933
--- /dev/null
+++ b/test/test_package_identification_python_setup_py.py
@@ -0,0 +1,89 @@
+# Copyright 2016-2018 Dirk Thomas
+# Copyright 2024 Open Source Robotics Foundation, Inc.
+# Licensed under the Apache License, Version 2.0
+
+from pathlib import Path
+from tempfile import TemporaryDirectory
+
+from colcon_core.package_descriptor import PackageDescriptor
+from colcon_python_setup_py.package_augmentation.python_setup_py \
+    import PythonPackageAugmentation
+from colcon_python_setup_py.package_identification.python_setup_py \
+    import _setup_information_cache
+from colcon_python_setup_py.package_identification.python_setup_py \
+    import PythonPackageIdentification
+import pytest
+
+
+def test_identify():
+    extension = PythonPackageIdentification()
+    augmentation_extension = PythonPackageAugmentation()
+
+    with TemporaryDirectory(prefix='test_colcon_') as basepath:
+        desc = PackageDescriptor(basepath)
+        desc.type = 'other'
+        assert extension.identify(desc) is None
+        assert desc.name is None
+
+        desc.type = None
+        _setup_information_cache.clear()
+        assert extension.identify(desc) is None
+        assert desc.name is None
+        assert desc.type is None
+
+        basepath = Path(basepath)
+        (basepath / 'setup.py').write_text(
+            'from setuptools import setup\n\n'
+            'setup(\n'
+            "  name='pkg-name',\n"
+            ')\n')
+        _setup_information_cache.clear()
+        assert extension.identify(desc) is None
+        assert desc.name == 'pkg-name'
+        assert desc.type == 'python'
+        assert not desc.dependencies
+        assert not desc.metadata
+
+        augmentation_extension.augment_package(desc)
+        assert set(desc.dependencies.keys()) == {'build', 'run', 'test'}
+        assert not desc.dependencies['build']
+        assert not desc.dependencies['run']
+        assert not desc.dependencies['test']
+
+        desc = PackageDescriptor(basepath)
+        desc.name = 'other-name'
+        _setup_information_cache.clear()
+        with pytest.raises(RuntimeError) as e:
+            extension.identify(desc)
+        assert str(e.value).endswith(
+            'Package name already set to different value')
+
+        (basepath / 'setup.py').write_text(
+            'from setuptools import setup\n\n'
+            'setup(\n'
+            "  name='other-name',\n"
+            "  maintainer='Foo Bar',\n"
+            "  maintainer_email='foobar@example.com',\n"
+            '  setup_requires=[\n'
+            "    'setuptools; sys_platform != \"win32\"',\n"
+            "    'colcon-core; sys_platform == \"win32\"',\n"
+            '  ],\n'
+            '  install_requires=[\n'
+            "    'runA > 1.2.3',\n"
+            "    'runB',\n"
+            '  ],\n'
+            '  zip_safe=False,\n'
+            ')\n')
+        _setup_information_cache.clear()
+        assert extension.identify(desc) is None
+        assert desc.name == 'other-name'
+        assert desc.type == 'python'
+        assert not desc.dependencies
+        assert not desc.metadata
+
+        augmentation_extension.augment_package(desc)
+        assert set(desc.dependencies.keys()) == {'build', 'run', 'test'}
+        assert desc.dependencies['build'] == {'setuptools', 'colcon-core'}
+        assert desc.dependencies['run'] == {'runA', 'runB'}
+        dep = next(x for x in desc.dependencies['run'] if x == 'runA')
+        assert dep.metadata['version_gt'] == '1.2.3'