Don't log time, logger can be formatted to include time #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Including time in logger pollutes loggers that already have a timestamp included. Developers can set their own logger through
Delayed::Worker.logger. Additionally, common logging platforms are able to determine time on ingestion such as Cloudwatch, Datadog, Scalyr, etc.Background
This pr initially included time 10 years ago when Rails didn't support time in logs: #37. 5 years later, this issue was opened asking for the same fix #859 but Rails still did not support it. Now, this is possible with Rails loggers using your own logger and setting
Rails.logger.datetime_formatto your own desired format, see https://stackify.com/rails-logger-and-rails-logging-best-practices/ for examples/tutorial.