-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an --ontop arg to keep the process alive for heroku #725
Conversation
…g. This will allow heroku dynos to work
00c7e65
to
27ce6b0
Compare
|
You are correct. It behaves exactly as you describe. I guess what I'd need to do is only 'ontop' the last worker to be started to keep the whole thing from going away in heroku. |
Right now what I'm doing is using the standard issue delayed_job with this script on heroku
|
This #615 is in the works, but I haven't had the chance to polish the rough edges |
Loss of logging is why I went with the solution in #615. I think I tried to fix logging by redirecting stdout/stderr etc from the child processes to the parent but I couldn't get it to work and don't remember why. |
when using daemonized DJ workers, heroku needs the parent process to stay alive. Otherwise, when it exits, the dyno will terminate, killing the workers.
This change adds --ontop to the command line options. It passed the :ontop parameter to the Daemonize call when set.
@dgobaud
Relates to issue #565 #615