Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sitipe Plugin] - Connected AP's not imported correctly #296

Closed
pascalwilbrink opened this issue Nov 17, 2023 · 2 comments · Fixed by #304
Closed

[Sitipe Plugin] - Connected AP's not imported correctly #296

pascalwilbrink opened this issue Nov 17, 2023 · 2 comments · Fixed by #304
Labels
bug Something isn't working

Comments

@pascalwilbrink
Copy link
Member

pascalwilbrink commented Nov 17, 2023

When adding a BayTypical to a Bay, the ConnectedAp's are not imported correctly.
This is because the IED that has been added gets a new name.
The ConnectedAp still points to the old IED name.

Logs

SITIPE Scl Import Logger - session start: 2023-11-17 16:39:19

2023-11-17 16:39:19 [Error] IedDevice::Init: Bay 'Vienna west'-'Europe_110kVViennawestA01' no ConnectedAP found for AccessPoint 'E'
2023-11-17 16:39:19 [INF] Topology::ReadIEDs: IED init Problem 'Europe_110kVViennawestA01' for parent 'Substation[Europe]/VoltageLevel[110kV]/Bay[Vienna west]' -> check!
2023-11-17 16:39:19 [Error] Topology::ReadIEDs: errors after IED init 'Substation[Europe]/VoltageLevel[110kV]/Bay[Vienna west]'
2023-11-17 16:39:19 [Error] ScdDocument::ReadIEDs: ReadIEDs failed for 'Substation[Europe]/VoltageLevel[110kV]/Bay[Vienna west]'
2023-11-17 16:39:19 [Error] SCDimportBL::StartImport: ReadIEDs error using SCD Path: 'C:\Users\al4056\Downloads\SITIPE-CoMPAS-demo\SYSCON_Europe_CV2-modifield2.scd'
2023-11-17 16:39:19 [INF] ExcelAddInFrame::StartImportFrmWorkbook4Scd: Log from Excel using AddIn:
[StrBuf]: Wbk Start at 2023-11-17 16:39:19

Fix
Change the IED Name after Importing that IED (https://github.com/com-pas/compas-open-scd/blob/main/packages/compas-open-scd/src/compas-editors/sitipe/sitipe-bay.ts#L570).
Update the Communication -> ConnnectedAP so that the IEDName of connectedAP still points to the correct IED.

Acceptance criteria:
Every reference to the new IED has an updated name

@Sander3003 Sander3003 added the bug Something isn't working label Nov 20, 2023
@Sander3003
Copy link
Member

Can is one be closed or are we waiting for an pull-request to finish?

@Sander3003
Copy link
Member

#304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants